Re: Race condition in InvalidateObsoleteReplicationSlots() - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Race condition in InvalidateObsoleteReplicationSlots()
Date
Msg-id 20210430155735.4r47novjepij4kz5@alap3.anarazel.de
Whole thread Raw
In response to Re: Race condition in InvalidateObsoleteReplicationSlots()  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
Hi,

On 2021-04-08 17:03:41 +0530, Amit Kapila wrote:
> I haven't tested the patch but I couldn't spot any problems while
> reading it. A minor point, don't we need to use
> ConditionVariableCancelSleep() at some point after doing
> ConditionVariableTimedSleep?

It's not really necessary - unless the CV could get deallocated as part
of dynamic shared memory or such.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: MaxOffsetNumber for Table AMs
Next
From: Andres Freund
Date:
Subject: Re: Race condition in InvalidateObsoleteReplicationSlots()