Re: Remove page-read callback from XLogReaderState. - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Remove page-read callback from XLogReaderState.
Date
Msg-id 20210406234907.GA19311@alvherre.pgsql
Whole thread Raw
In response to Re: Remove page-read callback from XLogReaderState.  (Thomas Munro <thomas.munro@gmail.com>)
List pgsql-hackers
On 2021-Apr-07, Thomas Munro wrote:

> On Wed, Apr 7, 2021 at 11:18 AM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> > BTRW it's funny that after these patches, "xlogreader" no longer reads
> > anything.  It's more an "xlog interpreter" -- the piece of code that
> > splits individual WAL records from a stream of WAL bytes that's caller's
> > responsibility to obtain somehow.  But (and, again, I haven't read this
> > patch recently) it still offers pieces that support a reader, in
> > addition to its main interface as the interpreter.  Maybe it's not a
> > totally stupid idea to split it in even more different files.
> 
> Yeah, I like "decoder", and it's already called that in some places...

Yeah, that works ...

-- 
Álvaro Herrera                            39°49'30"S 73°17'W
"Los trabajadores menos efectivos son sistematicamente llevados al lugar
donde pueden hacer el menor daño posible: gerencia."  (El principio Dilbert)



pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: Remove page-read callback from XLogReaderState.
Next
From: Andres Freund
Date:
Subject: Re: Autovacuum on partitioned table (autoanalyze)