Re: Making wait events a bit more efficient - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Making wait events a bit more efficient
Date
Msg-id 20210402201011.mrjd2p4pb2zg33qt@alap3.anarazel.de
Whole thread Raw
In response to Re: Making wait events a bit more efficient  (Zhihong Yu <zyu@yugabyte.com>)
Responses Re: Making wait events a bit more efficient  (Zhihong Yu <zyu@yugabyte.com>)
List pgsql-hackers
Hi,

On 2021-04-02 13:06:35 -0700, Zhihong Yu wrote:
> +extern PGDLLIMPORT uint32 *my_wait_event_info;
> 
> It seems volatile should be added to the above declaration. Since later:
> 
> +   *(volatile uint32 *) my_wait_event_info = wait_event_info;

Why? We really just want to make the store volatile, nothing else. I
think it's much better to annotate that we want individual stores to
happen regardless of compiler optimizations, rather than all
interactions with a variable.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Zhihong Yu
Date:
Subject: Re: Making wait events a bit more efficient
Next
From: Thomas Munro
Date:
Subject: Re: Add client connection check during the execution of the query