Re: Using COPY FREEZE in pgbench - Mailing list pgsql-hackers

> The feature is a little disappointing because if someone has partition
> tables then probably they have a lot of data and probably they would
> like freeze to work there. Maybe freeze would work on table partitions
> themselves, but I do not think it is worth the effort to do that.

Agreed.

> About v4 there is a typo in the doc "portioning":
> 
>      <command>pgbench</command> uses FREEZE option with 14 or later
>      version of <productname>PostgreSQL</productname> to speed up
>      subsequent <command>VACUUM</command> if portioning option is not
>      specified.
> 
> I'd suggest:
> 
>      <command>pgbench</command> uses the FREEZE option with 14 or later
>      version of <productname>PostgreSQL</productname> to speed up
>      subsequent <command>VACUUM</command>, unless partitions are enabled.

Thanks for pointing it out. Also I think that in "with 14 or later
version", "version" should be "versions".

Attached is the v5 patch.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp
diff --git a/doc/src/sgml/ref/pgbench.sgml b/doc/src/sgml/ref/pgbench.sgml
index 50cf22ba6b..f0b3a2a624 100644
--- a/doc/src/sgml/ref/pgbench.sgml
+++ b/doc/src/sgml/ref/pgbench.sgml
@@ -220,6 +220,9 @@ pgbench <optional> <replaceable>options</replaceable> </optional> <replaceable>d
             data is generated in <command>pgbench</command> client and then
             sent to the server. This uses the client/server bandwidth
             extensively through a <command>COPY</command>.
+            <command>pgbench</command> uses the FREEZE option with 14 or later
+            versions of <productname>PostgreSQL</productname> to speed up
+            subsequent <command>VACUUM</command>, unless partitions are enabled.
             Using <literal>g</literal> causes logging to print one message
             every 100,000 rows while generating data for the
             <structname>pgbench_accounts</structname> table.
diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.c
index e69d43b26b..44d39ad55d 100644
--- a/src/bin/pgbench/pgbench.c
+++ b/src/bin/pgbench/pgbench.c
@@ -3976,6 +3976,7 @@ initGenerateDataClientSide(PGconn *con)
     PGresult   *res;
     int            i;
     int64        k;
+    char        *copy_statement;
 
     /* used to track elapsed time and estimate of the remaining time */
     pg_time_usec_t start;
@@ -4022,7 +4023,18 @@ initGenerateDataClientSide(PGconn *con)
     /*
      * accounts is big enough to be worth using COPY and tracking runtime
      */
-    res = PQexec(con, "copy pgbench_accounts from stdin");
+
+    /*
+     * If partitioning is not enabled and server version is 14.0 or later, we
+     * can take account of freeze option of copy.
+     */
+    if (partitions == 0 && PQserverVersion(con) >= 140000)
+        copy_statement = "copy pgbench_accounts from stdin with (freeze on)";
+    else
+        copy_statement = "copy pgbench_accounts from stdin";
+
+    res = PQexec(con, copy_statement);
+
     if (PQresultStatus(res) != PGRES_COPY_IN)
     {
         pg_log_fatal("unexpected copy in result: %s", PQerrorMessage(con));