Re: Using COPY FREEZE in pgbench - Mailing list pgsql-hackers

From Tatsuo Ishii
Subject Re: Using COPY FREEZE in pgbench
Date
Msg-id 20210321.082648.773130439756064775.t-ishii@sraoss.co.jp
Whole thread Raw
In response to Re: Using COPY FREEZE in pgbench  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: Using COPY FREEZE in pgbench  (Tatsuo Ishii <ishii@sraoss.co.jp>)
List pgsql-hackers
Hi Fabien,

> Hello Tatsuo-san,
> 
>>> I have looked in the code of PQprotocolVersion. The only case in which
>>> it returns 0 is there's no connection. Yes, you are right. Once the
>>> connection has been successfuly established, there's no chance it
>>> fails. So I agree with you.
>>
>> Attached v3 patch addresses this.
>>
>>>> The "g" item in the section describing initialization steps
>>>> (i.e. option -I). I'd suggest just to replace "COPY" with "COPY
>>>> FREEZE" in the sentence.
>>>
>>> Ok. The section is needed to be modified.
>>
>> This is also addressed in the patch.
> 
> V3 works for me and looks ok. I changed it to ready in the CF app.

Thank you for your review!
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp



pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: proposal - psql - use pager for \watch command
Next
From: Tomas Vondra
Date:
Subject: Re: [HACKERS] Custom compression methods