Re: Key management with tests - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Key management with tests
Date
Msg-id 20210126032718.GB18075@momjian.us
Whole thread Raw
In response to Re: Key management with tests  (Bruce Momjian <bruce@momjian.us>)
Responses Re: Key management with tests
List pgsql-hackers
On Mon, Jan 25, 2021 at 07:09:44PM -0500, Bruce Momjian wrote:
> > May I suggest to use "git format-patch" to produce the patch files?  When
> > working with a series like this, trying to do patch handling manually
> > like you seem to be doing, is much more time-consuming and error prone.
> > For example, with a branch containing individual commits, you could use 
> >   git rebase -i origin/master -x "make install check-world"
> > or similar, so that each commit is built and tested individually.
> 
> I used "git format-patch".  Are you asking for seven commits that then
> generate seven files via one format-patch run?  Or is the primary issue
> that you want compile testing for each patch?

The attached patch meets both criteria.  I also clarified the README on
how initdb calls those functions.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee


Attachment

pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit
Next
From: Noah Misch
Date:
Subject: Re: Add SQL function for SHA1