Re: Is it useful to record whether plans are generic or custom? - Mailing list pgsql-hackers

From Kyotaro Horiguchi
Subject Re: Is it useful to record whether plans are generic or custom?
Date
Msg-id 20210125.141020.1672465005495895485.horikyota.ntt@gmail.com
Whole thread Raw
In response to Re: Is it useful to record whether plans are generic or custom?  (torikoshia <torikoshia@oss.nttdata.com>)
List pgsql-hackers
At Tue, 12 Jan 2021 20:36:58 +0900, torikoshia <torikoshia@oss.nttdata.com> wrote in 
> I suppose it would be normal practice to store past results of
> pg_stat_statements for future comparisons.
> If this is the case, I think that if we only add the number of
> generic plan execution, it will give us a hint to notice the cause
> of performance degradation due to changes in the plan between
> generic and custom.

Agreed.

> Attached a patch that just adds a generic call counter to
> pg_stat_statements.
> 
> Any thoughts?

Note that ActivePortal is the closest nested portal. So it gives the
wrong result for nested portals.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center



pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: About to add WAL write/fsync statistics to pg_stat_wal view
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: Is Recovery actually paused?