Re: [HACKERS] [PATCH] Generic type subscripting - Mailing list pgsql-hackers

From Dmitry Dolgov
Subject Re: [HACKERS] [PATCH] Generic type subscripting
Date
Msg-id 20210120162231.4oht6mdp6v76xfhs@localhost
Whole thread Raw
In response to Re: [HACKERS] [PATCH] Generic type subscripting  ("Dian M Fay" <dian.m.fay@gmail.com>)
Responses Re: [HACKERS] [PATCH] Generic type subscripting  ("Dian M Fay" <dian.m.fay@gmail.com>)
List pgsql-hackers
> On Tue Jan 19, 2021 at 1:42 PM EST, Pavel Stehule wrote:
>
> I found minor issues.
>
> Doc - missing tag
>
> and three whitespaces issues
>
> see attached patch

Thanks, I need to remember to not skipp doc building for testing process
even for such small changes. Hope now I didn't forget anything.

> On Wed, Jan 20, 2021 at 09:58:43AM -0500, Dian M Fay wrote:

> Here's a full editing pass on the documentation, with v45 and Pavel's
> doc-whitespaces-fix.patch applied. I also corrected a typo in one of the
> added hints.

Great! I've applied almost all of it, except:

+   A <type>jsonb</type> value will accept assignments to nonexistent subscript
+   paths as long as the nonexistent elements being traversed are all arrays.

Maybe I've misunderstood the intention, but there is no requirement
about arrays for creating such an empty path. I've formulated it as:

+   A <type>jsonb</type> value will accept assignments to nonexistent subscript
+   paths as long as the last existing path key is an object or an array.

Attachment

pgsql-hackers by date:

Previous
From: James Coleman
Date:
Subject: Re: Discarding DISCARD ALL
Next
From: "Dian M Fay"
Date:
Subject: Re: [HACKERS] [PATCH] Generic type subscripting