Re: Deadlock between backend and recovery may not be detected - Mailing list pgsql-hackers

From Kyotaro Horiguchi
Subject Re: Deadlock between backend and recovery may not be detected
Date
Msg-id 20201225.131611.1914966836446852743.horikyota.ntt@gmail.com
Whole thread Raw
In response to Re: Deadlock between backend and recovery may not be detected  (Fujii Masao <masao.fujii@oss.nttdata.com>)
Responses Re: Deadlock between backend and recovery may not be detected
List pgsql-hackers
At Wed, 23 Dec 2020 21:42:47 +0900, Fujii Masao <masao.fujii@oss.nttdata.com> wrote in 
> you. Attached
> is the updated of the patch. What about this version?

The patch contains a hunk in the following structure.

+    if (got_standby_lock_timeout)
+        goto cleanup;
+
+    if (got_standby_deadlock_timeout)
+    {
...
+    }
+
+cleanup:

It is eqivalent to

+    if (!got_standby_lock_timeout && got_standby_deadlock_timeout)
+    {
...
+    }

Is there any reason for the goto?

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center



pgsql-hackers by date:

Previous
From: "Tang, Haiying"
Date:
Subject: RE: [Patch] Optimize dropping of relation buffers using dlist
Next
From: Bharath Rupireddy
Date:
Subject: Re: Parallel Inserts in CREATE TABLE AS