Re: pgsql: revert removal of hex_decode() from ecpg from commit c3826f831e - Mailing list pgsql-committers

From Bruce Momjian
Subject Re: pgsql: revert removal of hex_decode() from ecpg from commit c3826f831e
Date
Msg-id 20201224233125.GB21105@momjian.us
Whole thread Raw
In response to Re: pgsql: revert removal of hex_decode() from ecpg from commit c3826f831e  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On Thu, Dec 24, 2020 at 06:25:56PM -0500, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > revert removal of hex_decode() from ecpg from commit c3826f831e
> > ecpglib on certain platforms can't handle the pg_log_fatal calls from
> > libraries.  This was reported by the buildfarm.  It needs a refactoring
> > and return value change if it is later removed.
> 
> Just for the record: even without the link failures, this was a pretty
> awful idea.  ecpglib has no business calling pg_log_fatal(), much less
> exit().

I should have realized it was the _lib_ calling it, and not ecpg itself.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee




pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: revert removal of hex_decode() from ecpg from commit c3826f831e
Next
From: Michael Paquier
Date:
Subject: Re: pgsql: move hex_decode() to /common so it can be called from frontend