Re: [PATCH] fix compilation with gnu89 - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [PATCH] fix compilation with gnu89
Date
Msg-id 20201130044944.y2tavdr52hk4g36d@alap3.anarazel.de
Whole thread Raw
In response to [PATCH] fix compilation with gnu89  (Rosen Penev <rosenp@gmail.com>)
Responses Re: [PATCH] fix compilation with gnu89  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi,

On 2020-11-29 20:33:41 -0800, Rosen Penev wrote:
> GCC 4.8.5 does not default to gnu99 or gnu11 like the newer versions.

We require C99 support since postgres 12, and configure should end up
choosing flags to make the compiler support that if possible.

As far as I can tell the code you changed doesn't actually exist in <=
11, so I don't see what problem it'd fix. And for newer branches you'd
obviously need a lot more changes than just this...

Regards,

Andres



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Improving spin-lock implementation on ARM.
Next
From: Tom Lane
Date:
Subject: Re: [PATCH] fix compilation with gnu89