On Sat, Nov 21, 2020 at 10:19:42AM +0900, Michael Paquier wrote:
> What you meant and what I meant was slightly different here. I meant
> publishing a header in src/include/common/ that would get installed,
> and I'd rather avoid that. And you mean to have the header for local
> consumption in src/common/. I would be fine with your third option as
> well. Your suggestion is more consistent with what we do for the rest
> of src/common/ and libpq actually. So I don't mind switching to
> that.
I got to look at your suggestion, and finished with the attached which
is pretty close my previous set, except that MSVC scripts as well as
the header includes needed a slight refresh.
Please note that the OpenSSL docs tell that EVP_DigestInit() is
obsolete and that applications should just use EVP_DigestInit_ex(), so
I have kept the original:
https://www.openssl.org/docs/man1.1.1/man3/EVP_DigestInit.html
The PG_CRYPTOHASH macro in cryptohash.h has been changed as you
suggested. What do you think?
--
Michael
