On Mon, Nov 23, 2020 at 09:11:26AM +0200, Heikki Linnakangas wrote:
> On 21/11/2020 21:32, Alvaro Herrera wrote:
>> This is pretty unhelpful; it would be better not to try to print the
>> data instead of dying. With that, at least you can know where the
>> problem is.
>>
>> This was introduced in d6061f83a166 (2015). Proposed patch to fix it
>> (by having the code print a null "data" instead of dying) is attached.
>
> Null seems misleading. Maybe something like "invalid", or print a warning?
How did you get into this state to begin with? get_raw_page() uses
ReadBufferExtended() which gives some level of protection already, so
shouldn't it be better to return an ERROR with ERRCODE_DATA_CORRUPTED
and the block involved?
--
Michael
