Re: [PATCH] ecpg: fix progname memory leak - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] ecpg: fix progname memory leak
Date
Msg-id 20201008013541.GB3457@paquier.xyz
Whole thread Raw
In response to [PATCH] ecpg: fix progname memory leak  (Maksim Kita <kitaetoya@gmail.com>)
Responses Re: [PATCH] ecpg: fix progname memory leak  (Bruce Momjian <bruce@momjian.us>)
Re: [PATCH] ecpg: fix progname memory leak  (John W Higgins <wishdev@gmail.com>)
List pgsql-hackers
On Wed, Oct 07, 2020 at 02:31:54PM +0300, Maksim Kita wrote:
> Fix progname memory leak in ecpg client.
> Issue taken from todo list https://wiki.postgresql.org/wiki/Todo.

FWIW, I don't see much point in doing that.  For one, we have a
more-or-less established rule that progname remains set until the
application leaves, and there are much more places where we leak
memory like that.  As one example, just see the various places where
we use pg_strdup for option parsing.  At the end, it does not really
matter as these are applications running for a short amount of time.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Andy Fan
Date:
Subject: Re: [PATCH] Keeps tracking the uniqueness with UniqueKey
Next
From: Peter Geoghegan
Date:
Subject: Re: new heapcheck contrib module