Re: pgsql: Prevent concurrent SimpleLruTruncate() for any given SLRU. - Mailing list pgsql-committers

From Noah Misch
Subject Re: pgsql: Prevent concurrent SimpleLruTruncate() for any given SLRU.
Date
Msg-id 20200815204818.GA2082300@rfd.leadboat.com
Whole thread Raw
In response to Re: pgsql: Prevent concurrent SimpleLruTruncate() for any given SLRU.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On Sat, Aug 15, 2020 at 04:39:05PM -0400, Tom Lane wrote:
> Noah Misch <noah@leadboat.com> writes:
> > Prevent concurrent SimpleLruTruncate() for any given SLRU.
> 
> I find it fairly scary that you've changed enum LockTagType in the
> back branches.  Are we quite certain that no extensions have compiled-in
> values of that enum?
> 
> Safer from an ABI standpoint would be to add the new value at the end,
> at least in the back branches.

Yeah, that was negligent.  Several PGXN modules do refer to locktags.  I'll
move it.



pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Prevent concurrent SimpleLruTruncate() for any given SLRU.
Next
From: Noah Misch
Date:
Subject: pgsql: Move new LOCKTAG_DATABASE_FROZEN_IDS to end of enum LockTagType.