Postgres Pro
Downloads
Home   >   mailing lists

Range checks of pg_test_fsync --secs-per-test and pg_test_timing --duration - Mailing list pgsql-hackers

From Michael Paquier
Subject Range checks of pg_test_fsync --secs-per-test and pg_test_timing --duration
Date
Msg-id 20200806062759.GE16470@paquier.xyz
Whole thread Raw
Responses Re: Range checks of pg_test_fsync --secs-per-test and pg_test_timing --duration  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
Tree view 
Hi all,

As $subject says, pg_test_fsync and pg_test_timing don't really check
the range of option values specified.  It is possible for example to
make pg_test_fsync run an infinite amount of time, and pg_test_timing
does not handle overflows with --duration at all.

These are far from being critical issues, but let's fix them at least
on HEAD.  So, please see the attached, where I have also added some
basic TAP tests for both tools.

Thanks,
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Ashutosh Sharma
Date:
Subject: Re: recovering from "found xmin ... from before relfrozenxid ..."
Next
From: "kato-sho@fujitsu.com"
Date:
Subject: RE: Creating foreign key on partitioned table is too slow