Re: LDAP check flapping on crake due to race - Mailing list pgsql-hackers

From Noah Misch
Subject Re: LDAP check flapping on crake due to race
Date
Msg-id 20200802061048.GA2207@rfd.leadboat.com
Whole thread Raw
In response to LDAP check flapping on crake due to race  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: LDAP check flapping on crake due to race
List pgsql-hackers
On Sun, Aug 02, 2020 at 05:29:57PM +1200, Thomas Munro wrote:
> There are one or two failures per month on crake.  It looks like when
> authentication is rejected, as expected in the tests, the psql process
> is exiting, but there is a race where the Perl script still wants to
> write a dummy query to its stdin (?), so you get:
> 
> psql: FATAL:  LDAP authentication failed for user "test1"
> ack Broken pipe: write( 13, 'SELECT 1' ) at
> /usr/share/perl5/vendor_perl/IPC/Run/IO.pm line 549.

Do you suppose a fix like e12a472 would cover this?  ("psql <&-" fails with
status 1 after successful authentication, and authentication failure gives
status 2.)



pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: LDAP check flapping on crake due to race
Next
From: Noah Misch
Date:
Subject: Re: SimpleLruTruncate() mutual exclusion