Re: [PATCH] Tab completion for VACUUM of partitioned tables - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Tab completion for VACUUM of partitioned tables
Date
Msg-id 20200729062119.GF28700@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] Tab completion for VACUUM of partitioned tables  (Masahiko Sawada <masahiko.sawada@2ndquadrant.com>)
Responses Re: [PATCH] Tab completion for VACUUM of partitioned tables  (Masahiko Sawada <masahiko.sawada@2ndquadrant.com>)
List pgsql-hackers
On Wed, Jul 29, 2020 at 01:27:07PM +0900, Masahiko Sawada wrote:
> Good catch. The patch looks good to me.

While this patch is logically correct.  I think that we should try to
not increase more the number of queries used to scan pg_class
depending on a list of relkinds.  For example, did you notice that
your new Query_for_list_of_vacuumables becomes the same query as
Query_for_list_of_indexables?  You can make your patch more simple.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: proposal: unescape_text function
Next
From: Hamid Akhtar
Date:
Subject: Re: Rethinking opclass member checks and dependency strength