Re: new heapcheck contrib module - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: new heapcheck contrib module
Date
Msg-id 20200717012532.GB29811@paquier.xyz
Whole thread Raw
In response to Re: new heapcheck contrib module  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Thu, May 14, 2020 at 03:50:52PM -0400, Tom Lane wrote:
> I think there's definitely value in corrupting data in some predictable
> (reproducible) way and verifying that the check code catches it and
> responds as expected.  Sure, this will not be 100% coverage, but it'll be
> a lot better than 0% coverage.

Skimming quickly through the patch, that's what is done in a way
similar to pg_checksums's 002_actions.pl.  So it seems fine to me to
use something like that for some basic coverage.  We may want to
refactor the test APIs to unify all that though.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Encoding of src/timezone/tznames/Europe.txt
Next
From: Masahiro Ikeda
Date:
Subject: Re: Transactions involving multiple postgres foreign servers, take 2