Re: min_safe_lsn column in pg_replication_slots view - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: min_safe_lsn column in pg_replication_slots view
Date
Msg-id 20200708230757.GA28114@alvherre.pgsql
Whole thread Raw
In response to Re: min_safe_lsn column in pg_replication_slots view  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: min_safe_lsn column in pg_replication_slots view  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 2020-Jul-08, Tom Lane wrote:

> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> > In absence of other suggestions I gave this the name XLogMBVarToSegs,
> > and redefined ConvertToXSegs to use that.  Didn't touch callers in
> > xlog.c to avoid pointless churn.  Pushed to both master and 13.
> 
> The buildfarm's sparc64 members seem unhappy with this.

Hmm.  Some of them are, yeah, but it's not universal.  For example
mussurana and ibisbill are not showing failures.

Anyway the error is pretty strange: only GetWALAvailability is showing a
problem, but the size calculation in the view function def is returning
a negative number, as expected.

So looking at the code in GetWALAvailability, what happens is that
targetSeg >= oldestSlotSeg, but we expect the opposite.  I'd bet for
targetSeg to be correct, since its input is just the slot LSN -- pretty
easy.  But for oldestSlotSeg, we have KeepLogSeg involved.

No immediate ideas ...

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Index Skip Scan (new UniqueKeys)
Next
From: Andrew Dunstan
Date:
Subject: Re: Is this a bug in pg_current_logfile() on Windows?