Re: Cache lookup errors with functions manipulation object addresses - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Cache lookup errors with functions manipulation object addresses
Date
Msg-id 20200702053516.GB431403@paquier.xyz
Whole thread Raw
In response to Re: Cache lookup errors with functions manipulation object addresses  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Cache lookup errors with functions manipulation object addresses
Re: Cache lookup errors with functions manipulation object addresses
List pgsql-hackers
On Thu, Mar 19, 2020 at 10:30:11PM +0900, Michael Paquier wrote:
> The new FORMAT_TYPE_* flag still makes sense to me while reading this
> code once again, as well as the extensibility of the new APIs for
> operators and procedures.  One doubt I still have is if we should
> really change the signature of getObjectDescription() to include the
> new missing_ok argument or if a new function should be introduced.
> I'd rather keep only one function as, even if this is called in many
> places in the backend, I cannot track down an extension using it, but
> I won't go against Alvaro's will either if he thinks something
> different as this is his original design and commit as of f8348ea3.

Attached is an updated patch set, because of conflicts in the docs.
Daniel, you are still registered as a reviewer of this patch, and it
is marked as ready for committer?  Do you have more comments?  Would
anybody have objections if I move on with 0001 and 0002 that extend
the APIs to get the procedure, operator and type names?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Rotten parts of src/backend/replication/README
Next
From: Bharath Rupireddy
Date:
Subject: Re: Cleanup - adjust the code crossing 80-column window limit