Re: pg_bsd_indent compiles bytecode - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pg_bsd_indent compiles bytecode
Date
Msg-id 20200629074858.GB330401@paquier.xyz
Whole thread Raw
In response to Re: pg_bsd_indent compiles bytecode  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Sat, Jun 27, 2020 at 06:54:04PM -0400, Tom Lane wrote:
> Having now checked, there isn't any such problem.  No .bc files are
> getting built except in src/backend and in other modules that feed
> into the backend, such as src/timezone and most of contrib.
>
> I do see .bc files getting built for pg_bsd_indent, as Alvaro reported.
> Seems like it must be a bug in the pgxs make logic, not anything more
> generic.

Yeah, and I think that it is caused by the following bit:
ifeq ($(with_llvm), yes)
all: $(addsuffix .bc, $(MODULES)) $(patsubst %.o,%.bc, $(OBJS))
endif

Shouldn't the latter part be ignored if PROGRAM is used?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: "Andrey V. Lepikhov"
Date:
Subject: Re: POC and rebased patch for CSN based snapshots
Next
From: Michael Paquier
Date:
Subject: Re: TAP tests and symlinks on Windows