Re: Update InsertPgAttributeTuple comment to match new signature - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Update InsertPgAttributeTuple comment to match new signature
Date
Msg-id 20200623053105.GK50978@paquier.xyz
Whole thread Raw
In response to Update InsertPgAttributeTuple comment to match new signature  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Update InsertPgAttributeTuple comment to match new signature  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Mon, Jun 22, 2020 at 04:27:18PM +0200, Daniel Gustafsson wrote:
> The comment for InsertPgAttributeTuple no longer, since 911e702077037996, match
> reality as attoptions isn't always initialized to NULL.  The attached removes
> mention of attoptions, and updates the list of always-NULL attributes to match
> what the code does (the git history didn't provide rationale for why they were
> omitted so it seemed like an oversight).

Looks right to me, good catch.  I'll apply that tomorrow my time
except if there are any objections in-between.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Resetting spilled txn statistics in pg_stat_replication
Next
From: James Sewell
Date:
Subject: Re: Threading in BGWorkers (!)