Postgres Pro
Downloads
Home   >   mailing lists

Re: TAP tests and symlinks on Windows - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: TAP tests and symlinks on Windows
Date
Msg-id 20200609071931.GE38342@paquier.xyz
Whole thread Raw
In response to TAP tests and symlinks on Windows  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: TAP tests and symlinks on Windows  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
Tree view 
On Mon, Jun 08, 2020 at 02:44:31PM +0200, Peter Eisentraut wrote:
> both contain a TAP skip notice "symlinks not supported on Windows".
>
> This is untrue.  Symlinks certainly work on Windows, and we have other TAP
> tests using them, for example for tablespaces.

> pg_rewind/t/004_pg_xlog_symlink.pl passes for me on Windows if I just remove
> the skip stuff.  My attached patch does that.

What's the version of your perl installation on Windows?  With 5.22, I
am still seeing that symlink() is not implemented, causing the tests
of pg_rewind to blow in flight with your patch (MSVC 2015 here).
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: Resetting spilled txn statistics in pg_stat_replication
Next
From: Andrew Gierth
Date:
Subject: Re: Speedup usages of pg_*toa() functions