Re: REINDEX CONCURRENTLY and indisreplident - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: REINDEX CONCURRENTLY and indisreplident
Date
Msg-id 20200604022336.GP89559@paquier.xyz
Whole thread Raw
In response to Re: REINDEX CONCURRENTLY and indisreplident  (Euler Taveira <euler.taveira@2ndquadrant.com>)
Responses Re: REINDEX CONCURRENTLY and indisreplident  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Wed, Jun 03, 2020 at 12:40:38PM -0300, Euler Taveira wrote:
> On Wed, 3 Jun 2020 at 03:54, Michael Paquier <michael@paquier.xyz> wrote:
>> I have bumped into $subject, causing a replica identity index to
>> be considered as dropped if running REINDEX CONCURRENTLY on it.  This
>> means that the old tuple information would get lost in this case, as
>> a REPLICA IDENTITY USING INDEX without a dropped index is the same as
>> NOTHING.
>
> LGTM. I tested in both versions (12, master) and it works accordingly.

Thanks for the review.  I'll try to get that fixed soon.

By the way, your previous email was showing up as part of my own email
with the indentation that was used so I missed it first.  That's the
case as well here:
https://www.postgresql.org/message-id/CAH503wDaejzhP7+wA-hHS6c7NzE69oWqe5Zf_TYFu1epAwp6EQ@mail.gmail.com
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: SIGSEGV from START_REPLICATION 0/XXXXXXX in XLogSendPhysical ()at walsender.c:2762
Next
From: Alvaro Herrera
Date:
Subject: Re: SIGSEGV from START_REPLICATION 0/XXXXXXX in XLogSendPhysical ()at walsender.c:2762