Postgres Pro
Downloads
Home   >   mailing lists

Re: Add "-Wimplicit-fallthrough" to default flags (was Re: pgsql:Support FETCH FIRST WITH TIES) - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Add "-Wimplicit-fallthrough" to default flags (was Re: pgsql:Support FETCH FIRST WITH TIES)
Date
Msg-id 20200511035925.GA7653@alvherre.pgsql
Whole thread Raw
In response to Re: Add "-Wimplicit-fallthrough" to default flags (was Re: pgsql:Support FETCH FIRST WITH TIES)  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: Add "-Wimplicit-fallthrough" to default flags (was Re: pgsql: Support FETCH FIRST WITH TIES)  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view 
On 2020-May-06, Alvaro Herrera wrote:

> This doesn't allow whitespace between "fall" and "through", which means
> we generate 217 such warnings currently.  Or we can just use
> -Wimplicit-fallthrough=3, which does allow whitespace (among other
> detritus).

If we're OK with patching all those places, I volunteer to do so.  Any
objections?  Or I can keep it at level 3, which can be done with minimal
patching.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Add -Wold-style-definition to CFLAGS?
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: +(pg_lsn, int8) and -(pg_lsn, int8) operators