Re: pg_restore error message - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: pg_restore error message
Date
Msg-id 20200508234516.GA13259@alvherre.pgsql
Whole thread Raw
In response to Re: pg_restore error message  (Ranier Vilela <ranier.vf@gmail.com>)
Responses Re: pg_restore error message
List pgsql-hackers
On 2020-May-07, Ranier Vilela wrote:

> Can suggest improvements?
> 
> 1. free (398 line) must be pg_free(buf)';

Yeah, there's a lot of frontend code that uses free() instead of
pg_free().  There are too many of these that worrying about a single one
would not improve things much.  I guess we could convert them all, but I
don't see much point.

> 2. %m, is a format to parameter, right?
>     But what parameter? Both fatal call, do not pass this parameter, or is
> it implied?

%m is an implied "strerror(errno)", implemented by our snprintf
replacement.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: pg_restore error message
Next
From: Thomas Munro
Date:
Subject: Re: pendingOps table is not cleared with fsync=off