Re: src/test/perl/TestLib.pm: check_pg_config needs/usr/include/postgresql/pg_config.h - Mailing list pgsql-hackers

From Christoph Berg
Subject Re: src/test/perl/TestLib.pm: check_pg_config needs/usr/include/postgresql/pg_config.h
Date
Msg-id 20200508194533.GB165095@msg.df7cb.de
Whole thread Raw
In response to Re: src/test/perl/TestLib.pm: check_pg_config needs /usr/include/postgresql/pg_config.h  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses ldap tls test fails in some environments
List pgsql-hackers
Re: Tom Lane
> But during "make check", that should be executing pg_config from the
> the temporary installation, so we should get the right answer no?
> 
> Conversely, in "make installcheck" scenarios, we definitely do want
> the value from the installed file, or so I should think.
> 
> Do you have a concrete scenario where you're getting wrong behavior?

I just added the extra tests to the postgresql-13 package and got
this:

$ cat build/src/test/ssl/tmp_check/log/regress_log_002_scram
No such file or directory at /srv/projects/postgresql/pg/master/build/../src/test/perl/TestLib.pm line 595.

But I just realized that the problem is caused by a Debian-specific
patch that removes the find_my_exec logic from pg_config and replaces
it with PGBINDIR. We need that patch because we install pg_config to
both /usr/bin and /usr/lib/postgresql/<version>/bin and want the same
output from both.

I'll revisit that to see if we can come up with a different solution.

Christoph



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: src/test/perl/TestLib.pm: check_pg_config needs /usr/include/postgresql/pg_config.h
Next
From: Tomas Vondra
Date:
Subject: Re: Improving estimates for TPC-H Q2