Re: Postgres Windows build system doesn't work with python installedin Program Files - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Postgres Windows build system doesn't work with python installedin Program Files
Date
Msg-id 20200507054544.GE11539@paquier.xyz
Whole thread Raw
In response to Re: Postgres Windows build system doesn't work with python installedin Program Files  (Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>)
Responses Re: Postgres Windows build system doesn't work with python installedin Program Files  (David Zhang <david.zhang@highgo.ca>)
List pgsql-hackers
On Wed, May 06, 2020 at 12:17:03AM +0200, Juan José Santamaría Flecha wrote:
> Please forgive me if I am being too nitpicky, but I find the comments a
> little too verbose, a usage format might be more visual and easier to
> explain:
>
> Usage: build [[CONFIGURATION] COMPONENT]
>
> The options are  case-insensitive.
> CONFIGURATION sets the configuration to build, "debug" or "release" (by
> default).
> COMPONENT defines a component to build. An empty option means all
> components.

Your comment makes sense to me.  What about the attached then?  On top
of documenting the script usage in the code, let's trigger it if it
gets called with more than 3 arguments.  What do you think?

FWIW, I forgot to mention that I don't think those warnings are worth
a backpatch.  No objections with improving things on HEAD of course.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: PG 13 release notes, first draft
Next
From: Amit Kapila
Date:
Subject: Re: PG compilation error with Visual Studio 2015/2017/2019