Re: pg_validatebackup -> pg_verifybackup? - Mailing list pgsql-hackers

From Andres Freund
Subject Re: pg_validatebackup -> pg_verifybackup?
Date
Msg-id 20200410203525.pdbtbm27uhczvyx6@alap3.anarazel.de
Whole thread Raw
In response to Re: pg_validatebackup -> pg_verifybackup?  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pg_validatebackup -> pg_verifybackup?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi,

On 2020-04-10 16:13:18 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > FWIW, I still think it's a mistake to accumulate all these bespoke
> > tools. We should go towards having one tool that can verify checksums,
> > validate backup manifests etc. Partially because it's more discoverable,
> > but also because it allows to verify multiple such properties in a
> > single pass, rather than reading the huge base backup twice.
> 
> Well, we're not getting there for v13.  Are you proposing that this
> patch just be reverted because it doesn't do everything at once?

No. I suggest choosing a name that's compatible with moving more
capabilities under the same umbrella at a later time (and I suggested
the same pre freeze too). Possibly adding a toplevel --verify-manifest
option as the only change besides naming.

Andres



pgsql-hackers by date:

Previous
From: David Steele
Date:
Subject: Re: pg_basebackup, manifests and backends older than ~12
Next
From: Tom Lane
Date:
Subject: Re: pg_validatebackup -> pg_verifybackup?