Postgres Pro
Downloads
Home   >   mailing lists

Re: Properly mark NULL returns in numeric aggregates - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Properly mark NULL returns in numeric aggregates
Date
Msg-id 20200410191404.l6bnmtxq3aelpbwz@alap3.anarazel.de
Whole thread Raw
In response to Properly mark NULL returns in numeric aggregates  (Jesse Zhang <sbjesse@gmail.com>)
Responses Re: Properly mark NULL returns in numeric aggregates  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: Properly mark NULL returns in numeric aggregates  (Jesse Zhang <sbjesse@gmail.com>)
List pgsql-hackers
Tree view 
Hi,

On 2020-04-09 16:22:11 -0700, Jesse Zhang wrote:
> We found that several functions -- namely numeric_combine,
> numeric_avg_combine, numeric_poly_combine, and int8_avg_combine -- are
> returning NULL without signaling the nullity of datum in fcinfo.isnull.
> This is obscured by the fact that the only functions in core (finalfunc
> for various aggregates) that those return values feed into happen to
> tolerate (or rather, not quite distinguish) zero-but-not-NULL trans
> values.

Shouldn't these just be marked as strict?

Greetings,

Andres Freund

pgsql-hackers by date:

Previous
From: David Steele
Date:
Subject: Re: pg_validatebackup -> pg_verifybackup?
Next
From: Andres Freund
Date:
Subject: Re: spin_delay() for ARM