Re: [Patch] Use internal pthreads reimplementation only whenbuilding with MSVC - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [Patch] Use internal pthreads reimplementation only whenbuilding with MSVC
Date
Msg-id 20200409215702.GA22804@alvherre.pgsql
Whole thread Raw
In response to [Patch] Use internal pthreads reimplementation only when buildingwith MSVC  (Sandro Mani <manisandro@gmail.com>)
Responses Re: [Patch] Use internal pthreads reimplementation only when building with MSVC
List pgsql-hackers
Hello,

On 2020-Apr-08, Sandro Mani wrote:

> The following patch, which we added to build mingw-postgresql on Fedora,
> makes the internal minimal pthreads reimplementation only used when building
> with MSVC, as on MINGW it causes symbol collisions with the symbols provided
> my winpthreads.

Are there any build-system tweaks needed to enable use of winpthreads?
If none are needed, why are all our mingw buildfarm members building
correctly?  I suggest that if you want to maintain "mingw-postgresql
built on Fedora", it would be a good idea to have a buildfarm animal
that tests it on a recurring basis.

Please do submit patches as separate attachments rather than in the
email body.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: pgsql: Rationalize GetWalRcv{Write,Flush}RecPtr().
Next
From: Andres Freund
Date:
Subject: Re: Catalog invalidations vs catalog scans vs ScanPgRelation()