Re: backup manifests - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: backup manifests
Date
Msg-id 20200409141055.GQ13712@tamriel.snowman.net
Whole thread Raw
In response to Re: backup manifests  (Fujii Masao <masao.fujii@oss.nttdata.com>)
Responses Re: backup manifests  (Fujii Masao <masao.fujii@oss.nttdata.com>)
List pgsql-hackers
Greetings,

* Fujii Masao (masao.fujii@oss.nttdata.com) wrote:
> On 2020/04/09 2:35, Robert Haas wrote:
> >On Wed, Apr 8, 2020 at 1:15 AM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
> >>When there is a backup_manifest in the database cluster, it's included in
> >>the backup even when --no-manifest is specified. ISTM that this is problematic
> >>because the backup_manifest is obviously not valid for the backup.
> >>So, isn't it better to always exclude the *existing* backup_manifest in the
> >>cluster from the backup, like backup_label/tablespace_map? Patch attached.
> >>
> >>Also I found the typo in the document. Patch attached.
> >
> >Both patches look good. The second one is definitely a mistake on my
> >part, and the first one seems like a totally reasonable change.
> >Thanks!
>
> Thanks for reviewing them! I pushed them.
>
> Please note that the commit messages have not been delivered to
> pgsql-committers yet.

They've been released and your address whitelisted.

Thanks,

Stephen

Attachment

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: Report error position in partition bound check
Next
From: Fujii Masao
Date:
Subject: Re: backup manifests