Re: Improving connection scalability: GetSnapshotData() - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Improving connection scalability: GetSnapshotData()
Date
Msg-id 20200408222534.56ys4lt7xd3dvgqu@alap3.anarazel.de
Whole thread Raw
In response to Re: Improving connection scalability: GetSnapshotData()  (Bruce Momjian <bruce@momjian.us>)
Responses Re: Improving connection scalability: GetSnapshotData()
List pgsql-hackers
Hi,

On 2020-04-08 18:06:23 -0400, Bruce Momjian wrote:
> If we don't commit this, where does this leave us with the
> old_snapshot_threshold feature?  We remove it in back branches and have
> no working version in PG 13?  That seems kind of bad.

I don't think this patch changes the situation for
old_snapshot_threshold in a meaningful way.

Sure, this patch makes old_snapshot_threshold scale better, and triggers
fewer unnecessary query cancellations.  But there still are wrong query
results, the tests still don't test anything meaningful, and the
determination of which query is cancelled is still wrong.

- Andres



pgsql-hackers by date:

Previous
From: Ants Aasma
Date:
Subject: Re: Parallel copy
Next
From: Mark Dilger
Date:
Subject: Perl modules for testing/viewing/corrupting/repairing your heap files