Re: error context for vacuum to include block number - Mailing list pgsql-hackers

From Justin Pryzby
Subject Re: error context for vacuum to include block number
Date
Msg-id 20200324041616.GA21443@telsasoft.com
Whole thread Raw
In response to Re: error context for vacuum to include block number  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: error context for vacuum to include block number
List pgsql-hackers
On Mon, Mar 23, 2020 at 02:25:14PM +0530, Amit Kapila wrote:
> > Yea, and it would be misleading if we reported "while scanning block..of
> > relation" if we actually failed while writing its FSM.
> >
> > My previous patches did this:
> >
> > +               case VACUUM_ERRCB_PHASE_VACUUM_FSM:
> > +                       errcontext("while vacuuming free space map of relation \"%s.%s\"",
> > +                                       cbarg->relnamespace, cbarg->relname);
> > +                       break;
> >
> 
> In what kind of errors will this help?

If there's an I/O error on an _fsm file, for one.

-- 
Justin



pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: replay pause vs. standby promotion
Next
From: Paul Jungwirth
Date:
Subject: Re: range_agg