Re: potential stuck lock in SaveSlotToPath() - Mailing list pgsql-hackers

From Andres Freund
Subject Re: potential stuck lock in SaveSlotToPath()
Date
Msg-id 20200318184542.w3zqaiz7rvax5wua@alap3.anarazel.de
Whole thread Raw
In response to potential stuck lock in SaveSlotToPath()  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: potential stuck lock in SaveSlotToPath()  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Hi,

On 2020-03-18 16:46:23 +0100, Peter Eisentraut wrote:
> When SaveSlotToPath() is called with elevel=LOG, the early exits don't
> release the slot's io_in_progress_lock.  Fix attached.

I'm a bit confused as to why we we ever call it with elevel = LOG
(i.e. why we have the elevel parameter at all). That seems to have been
there from the start, so it's either me or Robert that's to blame. But I
can't immediately see a reason for it?

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Minimal logical decoding on standbys
Next
From: Julien Rouhaud
Date:
Subject: Re: WAL usage calculation patch