Re: Small docs bugfix: make it clear what can be used in UPDATE FROMand DELETE USING - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Small docs bugfix: make it clear what can be used in UPDATE FROMand DELETE USING
Date
Msg-id 20200318162445.GG17915@momjian.us
Whole thread Raw
In response to Re: Small docs bugfix: make it clear what can be used in UPDATE FROM and DELETE USING  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Small docs bugfix: make it clear what can be used in UPDATE FROM and DELETE USING  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: Small docs bugfix: make it clear what can be used in UPDATE FROMand DELETE USING  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
On Tue, Mar 17, 2020 at 10:58:54PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > I have implemented the ideas above in the attached patch.  I have
> > synchronized the syntax to match SELECT, and synchronized the paragraphs
> > describing the item.
> 
> I think that the DELETE synopsis should look like
> 
>     [ USING <replaceable class="parameter">from_item</replaceable> [, ...] ]
> 
> so that there's not any question which part of the SELECT syntax we're
> talking about.  I also think that the running text in both cases should
> say in exactly these words "from_item means the same thing as it does
> in SELECT"; the wording you propose still seems to be dancing around
> the point, leaving readers perhaps not quite sure about what is meant.
> 
> In the DELETE case you could alternatively say "using_item means the same
> thing as from_item does in SELECT", but that doesn't really seem like an
> improvement to me.

OK, updated patch attached.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +

Attachment

pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: pg_stat_progress_basebackup - progress reporting forpg_basebackup, in the server side
Next
From: Justin Pryzby
Date:
Subject: Re: Autovacuum on partitioned table (autoanalyze)