Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Skip llvm bytecode generation if LLVM is missing - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [PATCH] Skip llvm bytecode generation if LLVM is missing
Date
Msg-id 20200311194322.a6t6h26k4frznneq@alap3.anarazel.de
Whole thread Raw
In response to [PATCH] Skip llvm bytecode generation if LLVM is missing  (Craig Ringer <craig@2ndquadrant.com>)
Responses Re: [PATCH] Skip llvm bytecode generation if LLVM is missing  (Craig Ringer <craig@2ndquadrant.com>)
Re: [PATCH] Skip llvm bytecode generation if LLVM is missing  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
List pgsql-hackers
Tree view 
Hi,

On 2020-03-11 11:25:28 +0800, Craig Ringer wrote:
> I propose that per the attached patch PGXS should simply skip adding
> the automatic dependency for .bc files if clang cannot be found.
> Extensions may still choose to explicitly declare the rule in their
> own Makefile if they want to force bitcode generation.

Hm, that seems like it could also cause silent failures (e.g. after a
package upgrade or such).

How about erroring out, but with an instruction that llvm can be
disabled with make NO_LLVM=1 or such?

Regards,

Andres

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Improve handling of parameter differences in physical replication
Next
From: Tom Lane
Date:
Subject: Re: v13 latest snapshot build error