Re: move DECLARE_INDEX from indexing.h? - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: move DECLARE_INDEX from indexing.h?
Date
Msg-id 20200306183147.GA28255@alvherre.pgsql
Whole thread Raw
In response to move DECLARE_INDEX from indexing.h?  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On 2020-Mar-06, Alvaro Herrera wrote:

> In his long bootstrap-reworking thread[1] John Naylor initially proposed
> moving the DECLARE_INDEX lines from indexing.h to each of the
> corresponding catalog files.  However, in the end that wasn't done;
> these lines are still in indexing.h.  Is there a reason for this?
> Wouldn't it make more sense to have the indexes for pg_attribute appear
> in catalog/pg_attribute.h, and so forth?

(In a quick experiment, simply moving the pg_aggregate indexes from
indexing.h to pg_aggregate.h appears to work with no further changes.)

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: move DECLARE_INDEX from indexing.h?
Next
From: Pavel Stehule
Date:
Subject: Re: proposal: schema variables