Re: [Patch] pg_rewind: options to use restore_command fromrecovery.conf or command line - Mailing list pgsql-hackers

On Thu, Mar 05, 2020 at 11:09:06PM -0300, Alvaro Herrera wrote:
> Hmm, doesn't the CF bot already validate the MSVC build?
>
> Splitting in two seems all right, but I think one commit that introduces
> dead code is not great.  It may make more sense to have one commit for
> common/archive.c, and a second commit that does fe_archive plus
> pg_rewind changes ...  If that doesn't work for whatever reason, then
> doing a single commit may be preferrable.

Thanks for the suggestion.  Avoiding dead code makes sense as well
here.  I'll think about this stuff a bit more first.
--
Michael