Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h - Mailing list pgsql-committers

From Michael Paquier
Subject Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
Date
Msg-id 20200306021025.GG52814@paquier.xyz
Whole thread Raw
In response to Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h  (David Steele <david@pgmasters.net>)
List pgsql-committers
On Thu, Mar 05, 2020 at 08:20:23PM -0500, David Steele wrote:
> Couldn't we use pageinspect?

Oh, indeed.  I forgot that we already have this function.  The tests
of page.sql don't care about the page size either, so it would be
enough to add a couple of calls with some hardcoded bytea input.
--
Michael

Attachment

pgsql-committers by date:

Previous
From: David Steele
Date:
Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
Next
From: Tom Lane
Date:
Subject: pgsql: Allow ALTER TYPE to change some properties of a base type.