Re: useless RangeIOData->typiofunc - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: useless RangeIOData->typiofunc
Date
Msg-id 20200305150240.GA8064@alvherre.pgsql
Whole thread Raw
In response to Re: useless RangeIOData->typiofunc  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 2020-Mar-05, Tom Lane wrote:

> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> > Thanks -- ISTM it makes more sense to put the FmgrInfo before the
> > typioparam too:
> 
> > typedef struct RangeIOData
> > {
> >     TypeCacheEntry *typcache;    /* range type's typcache entry */
> >     FmgrInfo    proc;            /* element type's I/O function */
> >     Oid         typioparam;      /* element type's I/O parameter */
> > } RangeIOData;
> 
> Yeah, WFM.  Maybe even rename the FmgrInfo to "typioproc"
> or the like?

Good idea, thanks!  Pushed with that change.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: David Steele
Date:
Subject: Re: Retiring support for pre-7.3 FK constraint triggers
Next
From: Daniel Gustafsson
Date:
Subject: Re: Retiring support for pre-7.3 FK constraint triggers