Re: Protect syscache from bloating with negative cache entries - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Protect syscache from bloating with negative cache entries
Date
Msg-id 20200122050341.GD174860@paquier.xyz
Whole thread Raw
In response to Re: Protect syscache from bloating with negative cache entries  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Tue, Jan 21, 2020 at 02:17:53PM -0500, Tom Lane wrote:
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
>> Hmm ... travis is running -Werror?  That seems overly strict.  I think
>> we shouldn't punt a patch because of that.
>
> Why not?  We're not going to allow pushing a patch that throws warnings
> on common compilers.  Or if that does happen, some committer is going
> to have to spend time cleaning it up.  Better to clean it up sooner.
>
> (There is, btw, at least one buildfarm animal using -Werror.)

I agree that it is good to have in Mr Robot.  More early detection
means less follow-up cleanup.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Add MAIN_RELATION_CLEANUP and SECONDARY_RELATION_CLEANUP optionsto VACUUM
Next
From: Michael Paquier
Date:
Subject: Re: We're getting close to the end of 2020-01 CF