Postgres Pro
Downloads
Home   >   mailing lists

Re: Remove page-read callback from XLogReaderState. - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Remove page-read callback from XLogReaderState.
Date
Msg-id 20200117192218.GA19889@alvherre.pgsql
Whole thread Raw
In response to Re: Remove page-read callback from XLogReaderState.  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-hackers
Tree view 
On 2020-Jan-17, Heikki Linnakangas wrote:

> I changed that by adding new function, XLogBeginRead(), that repositions the
> reader, and removed the 'lsn' argument from XLogReadRecord() altogether. All
> callers except one in findLastCheckPoint() pg_rewind.c positioned the reader
> once, and then just read sequentially from there, so I think that API is
> more convenient.

I like it.  +1

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: psql - add SHOW_ALL_RESULTS option
Next
From: David Fetter
Date:
Subject: Re: Let people set host(no)ssl settings from initdb