Re: [PATCH v1] pg_ls_tmpdir to show directories - Mailing list pgsql-hackers

From Justin Pryzby
Subject Re: [PATCH v1] pg_ls_tmpdir to show directories
Date
Msg-id 20200116003924.GJ26045@telsasoft.com
Whole thread Raw
In response to Re: [PATCH v1] pg_ls_tmpdir to show directories  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: [PATCH v1] pg_ls_tmpdir to show directories  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-hackers
On Wed, Jan 15, 2020 at 11:21:36AM +0100, Fabien COELHO wrote:
> I'm trying to think about how to get rid of the strange structure and hacks,
> and the arbitrary looking size 2 array.
> 
> Also the recursion is one step, but I'm not sure why, ISTM it could/should
> go on always?

Because tmpfiles only go one level deep.

> Looking at the code, ISTM that relying on a stack/list would be much cleaner
> and easier to understand. The code could look like:

I'm willing to change the implementation, but only after there's an agreement
about the desired behavior (extra column, one level, etc).

Justin



pgsql-hackers by date:

Previous
From: Jesse Zhang
Date:
Subject: Re: Use compiler intrinsics for bit ops in hash
Next
From: Michael Paquier
Date:
Subject: Re: Improve errors when setting incorrect bounds for SSL protocols