Re: Add pg_file_sync() to adminpack - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Add pg_file_sync() to adminpack
Date
Msg-id 20200114061756.GH1515@paquier.xyz
Whole thread Raw
In response to Re: Add pg_file_sync() to adminpack  (Julien Rouhaud <rjuju123@gmail.com>)
Responses Re: Add pg_file_sync() to adminpack  (Julien Rouhaud <rjuju123@gmail.com>)
List pgsql-hackers
On Mon, Jan 13, 2020 at 03:39:32PM +0100, Julien Rouhaud wrote:
> Actually, can't it create a security hazard, for instance if you call
> pg_file_sync() on a heap file and the calls errors out, since it's
> bypassing data_sync_retry?

Are you mistaking security with durability here?  By default, the
function proposed is only executable by a superuser, so that's not
really a security concern..  But I agree that failing to detect a
PANIC on a fsync for a sensitive Postgres file could lead to
corruptions.  That's why we PANIC these days.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Dilip Kumar
Date:
Subject: Re: PATCH: logical_work_mem and logical streaming of largein-progress transactions
Next
From: Julien Rouhaud
Date:
Subject: Re: Add pg_file_sync() to adminpack