Re: pgbench - use pg logging capabilities - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pgbench - use pg logging capabilities
Date
Msg-id 20200110004546.GE1702@paquier.xyz
Whole thread Raw
In response to Re: pgbench - use pg logging capabilities  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On Thu, Jan 09, 2020 at 09:27:42PM -0300, Alvaro Herrera wrote:
> On 2020-Jan-09, Fabien COELHO wrote:
>> -    if (unlikely(__pg_log_level <= PG_LOG_DEBUG))
>> +    if (pg_log_debug_level)
>>      {
>
> Umm ... I find the original exceedingly ugly, but the new line is
> totally impenetrable.

Maybe just a pg_logging_get_level() for consistency with the
_set_level() one, and then compare the returned result with
PG_LOG_DEBUG in pgbench?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: logical decoding : exceeded maxAllocatedDescs for .spill files
Next
From: "Deng, Gang"
Date:
Subject: RE: [PATCH] Resolve Parallel Hash Join Performance Issue