Re: Exposing keywords to clients - Mailing list pgsql-patches

From Tom Lane
Subject Re: Exposing keywords to clients
Date
Msg-id 20194.1209845214@sss.pgh.pa.us
Whole thread Raw
In response to Re: Exposing keywords to clients  ("Dave Page" <dpage@pgadmin.org>)
Responses Re: Exposing keywords to clients
List pgsql-patches
"Dave Page" <dpage@pgadmin.org> writes:
> Attached is an updated patch, giving the following output.

Oh, one other thing: dropping externs into random modules unrelated to
their source module is completely awful programming style, because there
is nothing preventing incompatible declarations.  Put those externs in
keywords.h instead.  I suspect you have ignored a compiler warning
about not declaring pg_get_keywords itself, too --- it should be
extern'd in builtins.h.

            regards, tom lane

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: Exposing keywords to clients
Next
From: "Dave Page"
Date:
Subject: Re: Exposing keywords to clients