Re: [PATCH v1] pg_ls_tmpdir to show directories - Mailing list pgsql-hackers

From Justin Pryzby
Subject Re: [PATCH v1] pg_ls_tmpdir to show directories
Date
Msg-id 20191228210953.GJ12890@telsasoft.com
Whole thread Raw
In response to Re: [PATCH v1] pg_ls_tmpdir to show directories  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: [PATCH v1] pg_ls_tmpdir to show directories  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-hackers
Here's a version which uses an array of directory_fctx, rather than of DIR and
location.  That avoids changing the data structure and collatoral implications
to pg_ls_dir().

Currently, this *shows* subdirs of subdirs, but doesn't decend into them.
So I think maybe toplevel subdirs should be shown, too.
And maybe the is_dir flag should be re-introduced (although someone could call
pg_stat_file if needed).
I'm interested to hear feedback on that, although this patch still isn't great.

Attachment

pgsql-hackers by date:

Previous
From: legrand legrand
Date:
Subject: Incremental View Maintenance: ERROR: out of shared memory
Next
From: Fabien COELHO
Date:
Subject: Re: TAP testing for psql's tab completion code