Hello.
I found that confirmed_flush in ReplicationSlot (PersistentData) is
pointed with a wrong name in the comments in slotfuncs.c
The attaches fixes that.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
diff --git a/src/backend/replication/slotfuncs.c b/src/backend/replication/slotfuncs.c
index 6683fc3f9b..0dce714a85 100644
--- a/src/backend/replication/slotfuncs.c
+++ b/src/backend/replication/slotfuncs.c
@@ -378,8 +378,8 @@ pg_physical_replication_slot_advance(XLogRecPtr moveto)
/*
* Helper function for advancing our logical replication slot forward.
*
- * The slot's restart_lsn is used as start point for reading records,
- * while confirmed_lsn is used as base point for the decoding context.
+ * The slot's restart_lsn is used as start point for reading records, while
+ * confirmed_flush is used as base point for the decoding context.
*
* We cannot just do LogicalConfirmReceivedLocation to update confirmed_flush,
* because we need to digest WAL to advance restart_lsn allowing to recycle
@@ -549,7 +549,7 @@ pg_replication_slot_advance(PG_FUNCTION_ARGS)
/*
* Check if the slot is not moving backwards. Physical slots rely simply
* on restart_lsn as a minimum point, while logical slots have confirmed
- * consumption up to confirmed_lsn, meaning that in both cases data older
+ * consumption up to confirmed_flush, meaning that in both cases data older
* than that is not available anymore.
*/
if (OidIsValid(MyReplicationSlot->data.database))
